Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Commit package-lock.json #5787

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[CI] Commit package-lock.json #5787

wants to merge 1 commit into from

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Dec 13, 2024

@chalin chalin added the CI/infra CI & infrastructure label Dec 13, 2024
@chalin chalin requested a review from a team as a code owner December 13, 2024 12:25
chalin
chalin commented Dec 13, 2024
View reviewed changes
.github/workflows/check-format.yml
- uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
cache: npm
cache-dependency-path: tmp/package-ci.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json will be used by default (IIRC)

@chalin chalin marked this pull request as draft December 13, 2024 12:28
@chalin
Copy link
Contributor Author

chalin commented Dec 13, 2024

Ah, more care will be needed in using this approach. Putting this in draft, I'll come back to it later.

@chalin chalin mentioned this pull request Dec 13, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/infra CI & infrastructure
Projects
SIG Comms: PRs & Issues
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Commit package-lock.json file?
1 participant
@chalin